Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed left right key confusion in comments. (IDFGH-2586) #4670

Closed
wants to merge 1 commit into from

Conversation

unDeadHerbs
Copy link
Contributor

"Left" and "Right" were swapped in some comments.

"Left" and "Right" were swapped in some comments.
@github-actions github-actions bot changed the title Fixed left right key confusion in comments. Fixed left right key confusion in comments. (IDFGH-2586) Jan 26, 2020
@Alvin1Zhang
Copy link
Collaborator

Thanks for reporting and sorry for the slow turnaround. Sorry that we are now during the holiday of Chinese Lunar New Year. Will update to you when we are back, thanks.

@CLAassistant
Copy link

CLA assistant check
All committers have signed the CLA.

@ghost
Copy link

ghost commented Sep 16, 2021

Hi, @unDeadHerbs

Could you please checkout to the 2078dfe and see whether the issue still exists?
If yes, please rebase your PR on the latest master branch.

We will handle this PR then.

Thanks

@espressif-bot espressif-bot added the Status: In Progress Work is in progress label Sep 16, 2021
@espressif-bot espressif-bot added Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: In Progress Work is in progress Resolution: NA Issue resolution is unavailable labels Jan 7, 2022
@Alvin1Zhang
Copy link
Collaborator

Thanks for your contribution, changes merged with 5f28c0c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants