lwip: enable ipv6 dns server retrieval from ndp (IDFGH-1769)#3118
Closed
mrrosen wants to merge 1 commit intoespressif:masterfrom
Closed
lwip: enable ipv6 dns server retrieval from ndp (IDFGH-1769)#3118mrrosen wants to merge 1 commit intoespressif:masterfrom
mrrosen wants to merge 1 commit intoespressif:masterfrom
Conversation
|
Michael R Rosen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Collaborator
|
@mrrosen Thanks for the contribution and sorry for the slow turnaround. We will look into PR. Thanks. |
github-actions
bot
changed the title
Author
|
@Alvin1Zhang any word/thoughts on this change? |
0xFEEDC0DE64
pushed a commit
to 0xFEEDC0DE64/esp-idf
that referenced
this pull request
May 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combined with espressif/esp-lwip#5, enables IPv6 DNS server address retrieval from Router Advertisements in NDP. Macro was missing from settings in port header file to enable this feature, so networks only supporting IPv6 (without DHCPv6 which doesnt seem supported yet in lwip used by ESP IDF) or only with IPv6 DNS servers can now be used as the DNS servers for lookups. Previously, IPv4 address was needed (and dhcp returns good DNS servers) to actually do a DNS lookup while all other network traffic was using IPv6.