Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp_lcd: Fix ST7789V display offset issue (IDFGH-14575) #15332

Closed
wants to merge 1 commit into from

Conversation

jomoly
Copy link

@jomoly jomoly commented Feb 4, 2025

The ST7789V LCD shows a 20-pixel offset issue due to missing display window initialization. This commit adds proper CASET and RASET commands in panel initialization to fix the problem.

Fixes #15331

Description

Fixed ST7789V LCD display offset issue by adding proper display window initialization commands (CASET/RASET) in panel_st7789_init().

Issue

  • Top 20 pixels show noise
  • Content is shifted down by 20 pixels
  • Bottom 20 pixels are cut off

Root Cause

Default initialization sequence lacks proper display window setup.

Solution

Added CASET and RASET commands to initialize display window properly:

  • CASET: Set column address range (0-239)
  • RASET: Set row address range (0-319)

Verification

Tested with:

  • Hardware: ESP32-S3 with ST7789V LCD (240x320)
  • Example: lcd_i80_display example
  • Result: Display content shows correctly without offset

Documentation

No documentation changes needed as this is a bug fix.

@espressif-bot espressif-bot added the Status: Opened Issue is new label Feb 4, 2025
@github-actions github-actions bot changed the title esp_lcd: Fix ST7789V display offset issue esp_lcd: Fix ST7789V display offset issue (IDFGH-14575) Feb 4, 2025
@CLAassistant
Copy link

CLAassistant commented Feb 4, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Feb 4, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello jomoly, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against a96919f

The ST7789V LCD shows a 20-pixel offset issue due to missing
display window initialization. This commit adds proper CASET
and RASET commands in panel initialization to fix the problem.

Fixes espressif#15331
@jomoly jomoly force-pushed the fix/st7789_display_offset branch from 335ad34 to a96919f Compare February 4, 2025 18:16
@asaitov
Copy link

asaitov commented Feb 4, 2025

What if display resolution is not 240x320? I believe these changes are device specific and should not be part of ST7789 driver implementation.

ESP_RETURN_ON_ERROR(esp_lcd_panel_io_tx_param(io, ST7789_CMD_RAMCTRL, (uint8_t[]) {
st7789->ramctl_val_1, st7789->ramctl_val_2
}, 2), TAG, "io tx param failed");

// Add display window initialization
// Set column address range (CASET)
ESP_RETURN_ON_ERROR(esp_lcd_panel_io_tx_param(io, LCD_CMD_CASET, (uint8_t[]) {
Copy link
Collaborator

@suda-morris suda-morris Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CASET and RASET are also set in the panel_st7789_draw_bitmap. So maybe here is duplicated.

@suda-morris suda-morris closed this Feb 7, 2025
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: Won't Do This will not be worked on and removed Status: Opened Issue is new labels Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Won't Do This will not be worked on Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

esp_lcd: ST7789V display offset issue (IDFGH-14574)
5 participants