Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #13293: Flush rgb lcd PSRAM framebuffers after allocation (IDFGH-12244) #13294

Closed
wants to merge 1 commit into from

Conversation

seijikun
Copy link
Contributor

@seijikun seijikun commented Feb 29, 2024

Framebuffers are allocated using calloc, which also zero's the buffer. This zeroing is done by the CPU and thus uses the CPU's writeback cache for the PSRAM. If the framebuffer is not flushed after allocation, the DMA hardware is going to read stale data and push that to the display hardware.

This fixes: #13293

@CLAassistant
Copy link

CLAassistant commented Feb 29, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Feb 29, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello seijikun, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 38f4658

@github-actions github-actions bot changed the title Fix #13293: Flush rgb lcd PSRAM framebuffers after allocation Fix #13293: Flush rgb lcd PSRAM framebuffers after allocation (IDFGH-12244) Feb 29, 2024
Flush PSRAM framebuffers after allocation to avoid visual corruption.
@suda-morris
Copy link
Collaborator

Thanks for the fix!

@suda-morris
Copy link
Collaborator

sha=38f46583a46d6e44239ee1c16852d27b760d8e3d

@suda-morris suda-morris added the PR-Sync-Merge Pull request sync as merge commit label Mar 1, 2024
espressif-bot pushed a commit that referenced this pull request Mar 6, 2024
Flush PSRAM framebuffers after allocation to avoid visual corruption.

Merges #13294
Closes #13293
@suda-morris
Copy link
Collaborator

merged in c755a62

we will backport this fix to 5.2/5.1/5.0 soon

@suda-morris suda-morris closed this Mar 6, 2024
espressif-bot pushed a commit that referenced this pull request Mar 7, 2024
Flush PSRAM framebuffers after allocation to avoid visual corruption.

Merges #13294
Closes #13293
espressif-bot pushed a commit that referenced this pull request Mar 13, 2024
Flush PSRAM framebuffers after allocation to avoid visual corruption.

Merges #13294
Closes #13293
espressif-bot pushed a commit that referenced this pull request Mar 13, 2024
Flush PSRAM framebuffers after allocation to avoid visual corruption.

Merges #13294
Closes #13293
DarkZeros pushed a commit to DarkZeros/esp-idf that referenced this pull request May 3, 2024
Flush PSRAM framebuffers after allocation to avoid visual corruption.

Merges espressif#13294
Closes espressif#13293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ESP32S3] [esp_lcd rgb] PSRAM Framebuffers are not flushed after allocation (IDFGH-12243)
3 participants