-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #13293: Flush rgb lcd PSRAM framebuffers after allocation (IDFGH-12244) #13294
Conversation
👋 Hello seijikun, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Flush PSRAM framebuffers after allocation to avoid visual corruption.
Thanks for the fix! |
sha=38f46583a46d6e44239ee1c16852d27b760d8e3d |
merged in c755a62 we will backport this fix to 5.2/5.1/5.0 soon |
Flush PSRAM framebuffers after allocation to avoid visual corruption. Merges espressif#13294 Closes espressif#13293
Framebuffers are allocated using calloc, which also zero's the buffer. This zeroing is done by the CPU and thus uses the CPU's writeback cache for the PSRAM. If the framebuffer is not flushed after allocation, the DMA hardware is going to read stale data and push that to the display hardware.
This fixes: #13293