-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove validation of pins for LCD output. (IDFGH-12038) #13103
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a bunch of cases you might want some pins not exposed. Eg. * Reading say 8 bit data and outputting the top 5 bits, discarding the rest by not mapping those data pins to output pins * Not using hsync/vsync because sync data is embedded within the data bits for more timing flexibility (eg. interlacing). * Using the LCD module as a high speed parallel data output bus, with no need for sync/control pins. Removing this validation makes these cases work.
Log
|
github-actions
bot
changed the title
Remove validation of pins for LCD output.
Remove validation of pins for LCD output. (IDFGH-12038)
Feb 4, 2024
sha=a2e0b9891fe23a31aa364a74382c6ce09381e1c6 |
espressif-bot
added
Status: In Progress
Work is in progress
Status: Reviewing
Issue is being reviewed
Status: Done
Issue is done internally
Resolution: NA
Issue resolution is unavailable
and removed
Status: Opened
Issue is new
Status: In Progress
Work is in progress
Status: Reviewing
Issue is being reviewed
labels
Feb 5, 2024
espressif-bot
pushed a commit
that referenced
this pull request
Feb 8, 2024
There are a bunch of cases you might want some pins not exposed. Eg. * Reading say 8 bit data and outputting the top 5 bits, discarding the rest by not mapping those data pins to output pins * Not using hsync/vsync because sync data is embedded within the data bits for more timing flexibility (eg. interlacing). * Using the LCD module as a high speed parallel data output bus, with no need for sync/control pins. Removing this validation makes these cases work. Merges #13103
espressif-bot
pushed a commit
that referenced
this pull request
Feb 20, 2024
There are a bunch of cases you might want some pins not exposed. Eg. * Reading say 8 bit data and outputting the top 5 bits, discarding the rest by not mapping those data pins to output pins * Not using hsync/vsync because sync data is embedded within the data bits for more timing flexibility (eg. interlacing). * Using the LCD module as a high speed parallel data output bus, with no need for sync/control pins. Removing this validation makes these cases work. Merges #13103
espressif-bot
pushed a commit
that referenced
this pull request
Mar 1, 2024
There are a bunch of cases you might want some pins not exposed. Eg. * Reading say 8 bit data and outputting the top 5 bits, discarding the rest by not mapping those data pins to output pins * Not using hsync/vsync because sync data is embedded within the data bits for more timing flexibility (eg. interlacing). * Using the LCD module as a high speed parallel data output bus, with no need for sync/control pins. Removing this validation makes these cases work. Merges #13103
espressif-bot
pushed a commit
that referenced
this pull request
Mar 1, 2024
There are a bunch of cases you might want some pins not exposed. Eg. * Reading say 8 bit data and outputting the top 5 bits, discarding the rest by not mapping those data pins to output pins * Not using hsync/vsync because sync data is embedded within the data bits for more timing flexibility (eg. interlacing). * Using the LCD module as a high speed parallel data output bus, with no need for sync/control pins. Removing this validation makes these cases work. Merges #13103
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PR-Sync-Merge
Pull request sync as merge commit
Resolution: NA
Issue resolution is unavailable
Status: Done
Issue is done internally
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a bunch of cases you might want some pins not exposed.
Eg.
Reading say 8 bit data and outputting the top 5 bits, discarding the rest by not mapping those data pins to output pins
Not using hsync/vsync because sync data is embedded within the data bits for more timing flexibility (eg. interlacing).
Using the LCD module as a high speed parallel data output bus, with no need for sync/control pins.
Removing this validation makes these cases work.