-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix (esp_lcd): Don't assume panels are 16bit in VSYNC restart logic (IDFGH-11941) #13020
Conversation
👋 Hello bwhitman, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
…sp-idf into lcd_restart_dont_assume_16bit
sha=25fba0a783701263bf1c576aac2c089fddddcc66 |
merged in commit ff840b6 |
I'm using RGB332 for my RGB panel. 8 bits a pixel.
I tried using
CONFIG_LCD_RGB_RESTART_IN_VSYNC
and found that it permanently corrupted (shifted) the screen, instead of fixing shifts.I found that
esp_lcd
assumes a 16-bit display during the transmission logic and doesn't checkfb_bits_per_pixel
.This PR is a fix for that error so that restarting in VSYNC doesn't permanently shift the screen.
I also fixed what I believe to be a smaller error in prefilling the "second" bounce buffer
[1]
, was[0]
.