espcoredump: Support for not overwriting existing core dump in flash (IDFGH-10907) #12105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
nomis
force-pushed
the
core-dump-no-overwrite
branch
from
42e3bec
to
6aaa0ce
Compare
Think this is simpler language: "Existing coredump found. Will not overwrite." |
If there's an unattended boot loop or a crash that causes another crash on the next boot, it needs to be possible to avoid overwriting a saved core dump with another core dump. Add an option to do this and skip writing core dumps if the partition isn't empty. Fixes espressif#12027.
nomis
force-pushed
the
core-dump-no-overwrite
branch
from
6aaa0ce
to
ee3e01c
Compare
|
I've rewritten the warning message to be clear about what happened |
espressif-bot
added
Status: Selected for Development
|
sha=ee3e01cf5c556e80615fd58b1baacf570865f679 |
espressif-bot
added
Status: Done
|
The MR has been merged internally, it will be synced to Github after passing the internal CI |
espressif-bot
pushed a commit
that referenced
this pull request
Nov 7, 2023
If there's an unattended boot loop or a crash that causes another crash on the next boot, it needs to be possible to avoid overwriting a saved core dump with another core dump. Add an option to do this and skip writing core dumps if the partition isn't empty. Fixes #12027. Mergeshttps://github.com//pull/12105
movsb
pushed a commit
to movsb/esp-idf
that referenced
this pull request
Dec 1, 2023
If there's an unattended boot loop or a crash that causes another crash on the next boot, it needs to be possible to avoid overwriting a saved core dump with another core dump. Add an option to do this and skip writing core dumps if the partition isn't empty. Fixes espressif#12027. Mergeshttps://github.com/espressif/pull/12105
|
Thanks for contribution again, changes have been merged with 1feb3c9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there's an unattended boot loop or a crash that causes another crash on the next boot, it needs to be possible to avoid overwriting a saved core dump with another core dump.
Add an option to do this and skip writing core dumps if the partition isn't empty.
Fixes #12027.