apply the same USB descriptor's iSerialNumber logic for ESP32-S2 as t… #7563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he ESP32-S3 already has
me-no-dev
reviewed
Dec 10, 2022
cores/esp32/USB.cpp
Outdated
| #endif | ||
| #ifndef USB_SERIAL | ||
| #if CONFIG_IDF_TARGET_ESP32S3 | ||
| #if CONFIG_IDF_TARGET_ESP32S2 || CONFIG_IDF_TARGET_ESP32S3 |
There was a problem hiding this comment.
The USB bootloader inside ESP32-S2 uses Serial "0". This is here for that exact reason. Please revert this change and set it manually if you need something specific.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
ESP32-S3 is currently using certain method to assign a default USB iSerialNumber field for USB descriptor by specifying "_ MAC _" keyword.
This PR applies the same method to the ESP32-S2 target as well.