Skip to content

Fix SerialBT.flush #3579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 20, 2020
Merged

Fix SerialBT.flush #3579

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab96650
Fix flush
mishafarms Dec 17, 2019
f859a91
Update BluetoothSerial.cpp
me-no-dev Jan 20, 2020
b2bbeec
Merge branch 'master' into master
me-no-dev Jan 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion libraries/BluetoothSerial/src/BluetoothSerial.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,7 +652,11 @@ size_t BluetoothSerial::write(const uint8_t *buffer, size_t size)

void BluetoothSerial::flush()
{
while(read() >= 0){}
if (_spp_tx_queue != NULL){
while(uxQueueMessagesWaiting(_spp_tx_queue) > 0){
delay(50);
Copy link
Member

@me-no-dev me-no-dev Jan 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

50 is a bit too much :) there ought to be a better way.

}
}
}

void BluetoothSerial::end()
Expand Down