-
Couldn't load subscription status.
- Fork 7.7k
Add "WEMOS LoLin32" boards support. #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
variants/lolin32/pins_arduino.h
Outdated
| static const uint8_t SDA = 21; | ||
| static const uint8_t SCL = 22; | ||
|
|
||
| static const uint8_t SS = 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't SS be GPIO 5?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ESP32's "General purpose SPI" can be remap to any GPIO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true, but it will not work just by defining it here ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I'm merging this now and will make the necessary adjustments to make your SS pin work.
Keep in mind that GPIO2 is a bootstrap pin that is pulled down by default (like GPIO15 on ESP8266) and that does not make it a very good SS pin, because it will have the slave selected on boot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you, changed the SS to GPIO5.
Thank you.
Update build.sh
update esp8266 option names
fix(esp32:m5stack_atoms3) : Update pins_arduino.h of variant m5stack_atoms3 with correct LED_BUILTIN value matching GPIO #35
@projectgus
@me-no-dev
Add "WEMOS LoLin32" boards support.
Thank you.