Skip to content

Conversation

@lucasssvaz
Copy link
Member

Description of Change

This PR adds the peer's IRK information and fixes the following issues:

  • Deadlock during authentication under certain conditions
  • Deinit function not working as expected
  • Race condition for notifications

Test Scenarios

Tested locally

Related links

Closes #11938
Closes #11906

@lucasssvaz lucasssvaz self-assigned this Oct 25, 2025
@lucasssvaz lucasssvaz requested a review from SuGlider as a code owner October 25, 2025 01:50
@lucasssvaz lucasssvaz added the Area: BLE Issues related to BLE label Oct 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello lucasssvaz, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 4f1f2e8

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2025

Test Results

 76 files   76 suites   18m 27s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit 4f1f2e8.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2025

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C50‼️ +5K0.00⚠️ +0.72000.000.00
ESP32P40‼️ +5K0.00⚠️ +0.71000.000.00
ESP32S30‼️ +5K0.00⚠️ +0.80000.000.00
ESP32C30‼️ +5K0.00⚠️ +0.90000.000.00
ESP32C60‼️ +6K0.00⚠️ +0.78000.000.00
ESP32H20‼️ +5K0.00⚠️ +0.76000.000.00
ESP320‼️ +5K0.00⚠️ +0.50000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C5ESP32P4ESP32S3ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/BLE/examples/Beacon_Scanner⚠️ +2500⚠️ +2500⚠️ +3560⚠️ +2480⚠️ +2400⚠️ +2420⚠️ +6720
libraries/BLE/examples/Client⚠️ +2480⚠️ +2480⚠️ +3720⚠️ +2480⚠️ +2460⚠️ +2400⚠️ +8760
libraries/BLE/examples/Client_secure_static_passkey‼️ +5K0‼️ +5K0‼️ +4K0‼️ +5K0‼️ +5K0‼️ +5K0‼️ +5K0
libraries/BLE/examples/EddystoneTLM_Beacon⚠️ +2460⚠️ +2380⚠️ +3720⚠️ +2380⚠️ +2460⚠️ +2460⚠️ +6720
libraries/BLE/examples/EddystoneURL_Beacon⚠️ +2380⚠️ +2460⚠️ +3560⚠️ +2460⚠️ +2380⚠️ +2380⚠️ +6560
libraries/BLE/examples/Notify⚠️ +2380⚠️ +2480⚠️ +3720⚠️ +2380⚠️ +2460⚠️ +2460⚠️ +6480
libraries/BLE/examples/Scan⚠️ +2380⚠️ +2460⚠️ +3720⚠️ +2380⚠️ +2460⚠️ +2460⚠️ +6600
libraries/BLE/examples/Server⚠️ +2380⚠️ +2460⚠️ +3720⚠️ +2380⚠️ +2460⚠️ +2460⚠️ +6600
libraries/BLE/examples/Server_multiconnect⚠️ +2480⚠️ +2400⚠️ +3560⚠️ +2480⚠️ +2380⚠️ +2400⚠️ +6480
libraries/BLE/examples/Server_secure_authorization⚠️ +2380--⚠️ +3720⚠️ +2460⚠️ +2460⚠️ +2460--
libraries/BLE/examples/Server_secure_static_passkey‼️ +5K0‼️ +5K0‼️ +5K0‼️ +5K0‼️ +6K0‼️ +5K0‼️ +5K0
libraries/BLE/examples/UART⚠️ +2480⚠️ +2380⚠️ +3720⚠️ +2460⚠️ +2400⚠️ +2400⚠️ +6440
libraries/BLE/examples/Write⚠️ +2480⚠️ +2400⚠️ +3720⚠️ +2460⚠️ +2400⚠️ +2400⚠️ +6600
libraries/BLE/examples/iBeacon⚠️ +2460⚠️ +2380⚠️ +3640⚠️ +2480⚠️ +2380⚠️ +2380⚠️ +6440

@lucasssvaz lucasssvaz marked this pull request as draft October 27, 2025 03:24
@lucasssvaz lucasssvaz added the Status: In Progress ⚠️ Issue is in progress label Oct 27, 2025
@lucasssvaz lucasssvaz marked this pull request as ready for review October 28, 2025 16:22
@lucasssvaz lucasssvaz added Status: Review needed Issue or PR is awaiting review and removed Status: In Progress ⚠️ Issue is in progress labels Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: BLE Issues related to BLE Status: Review needed Issue or PR is awaiting review

Projects

None yet

1 participant