Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(camera): Update resolutions and remove face detection #10814

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

me-no-dev
Copy link
Member

320x320 is removed as option for OV2640 as it is not supported (indexes are updated)

Fixes: #10801
Fixes: #10769

@me-no-dev me-no-dev added the Status: Review needed Issue or PR is awaiting review label Jan 6, 2025
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Messages
📖 This PR seems to be quite large (total lines of code: 1903), you might consider splitting it into smaller PRs

👋 Hello me-no-dev, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against adb5fe9

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S3💚 -704‼️ +4K💚 -0.07⚠️ +0.430⚠️ +4960.00⚠️ +0.83
ESP32S2💚 -704‼️ +3K💚 -0.07⚠️ +0.330⚠️ +360.00⚠️ +0.06
ESP32💚 -704‼️ +12K💚 -0.07‼️ +1.160⚠️ +760.00⚠️ +0.12
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAM
ESP32/examples/Camera/CameraWebServer‼️ +4K⚠️ +496‼️ +3K⚠️ +36‼️ +12K⚠️ +76

@me-no-dev me-no-dev added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Jan 7, 2025
@me-no-dev me-no-dev merged commit 30b97d1 into master Jan 7, 2025
21 checks passed
@me-no-dev me-no-dev deleted the bugfix/camera_resolutions branch January 7, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
1 participant