unused parameter in BLERemoteService::getCharacteristics()

[cyberman54]

My compiler complains on a unused, but set, parameter in BLERemoteService::getCharacteristics():

*pCharacteristicMap = m_characteristicMapByHandle;
ist set, but neither used in the function, nor returned by it.

Maybe shall this function have a return value, other than void()?

/cc @Kolban

[chegewara]

I dont remember now why there is 2 getCharacteristics(), but you can use this one:
https://github.com/espressif/arduino-esp32/blob/master/libraries/BLE/src/BLERemoteService.cpp#L217

[cyberman54]

@chegewara thanks for the hint! Would be nice to delete the redundant function, if not needed (where?), to get rid of the compiler warning.

[chegewara]

Feel free to make PR, for example add this in function with warning:
(void)pCharacteristicMap

[cyberman54]

I am careful to make changes here, as long as i don't know sure what i am doing in this code.

[chegewara]

It is easy change, you can try it in your code. That change does nothing in code except is fooling compiler.

[cyberman54]

issue is now adressed by PR #4669

[stale]

[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

[stale]

[STALE_DEL] This stale issue has been automatically closed. Thank you for your contributions.