Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HM3301 AQI int8 overflow #3361

Merged
merged 1 commit into from
Apr 10, 2022
Merged

Fix HM3301 AQI int8 overflow #3361

merged 1 commit into from
Apr 10, 2022

Conversation

calco88
Copy link
Contributor

@calco88 calco88 commented Apr 6, 2022

What does this implement/fix?

HM3301 AQI calculation was overflowing to negative values when AQI > 127 due to usage of int8 where int16 should've been used.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes HM3301 AQI Calculation Is Wrong

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

@jesserockz
Copy link
Member

Thanks

@jesserockz jesserockz merged commit a2d0c1b into esphome:dev Apr 10, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jesserockz jesserockz jesserockz approved these changes

Assignees
No one assigned
Labels
integration: hm3301 small-pr
Projects
ESPHome Dev
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HM3301 AQI Calculation Is Wrong
2 participants
@calco88 @jesserockz