Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ethernet pin config for olimex esp32-poe board #166

Merged
merged 1 commit into from
Feb 23, 2019
Merged

Add Ethernet pin config for olimex esp32-poe board #166

merged 1 commit into from
Feb 23, 2019

Conversation

setola
Copy link
Contributor

@setola setola commented Feb 22, 2019

Description:

Adde pin configuration for Olimex ESP32-POE board

Related issue (if applicable): adds documentation for a single board
Pull request in esphomeyaml with YAML changes (if applicable): OttoWinter/esphomeyaml#
Pull request in esphomelib with C++ framework changes (if applicable): OttoWinter/esphomelib#

Checklist:

  • The documentation change has been tested and compiles correctly.
  • Branch: next is for changes and new documentation that will go public with the next esphomelib release. Fixes, changes and adjustments for the current release should be created against current.

@OttoWinter OttoWinter changed the title added pin config for olimex esp32-poe board Add Ethernet pin config for olimex esp32-poe board Feb 22, 2019
Copy link
Member

@OttoWinter OttoWinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Maybe we should also add what board should be selected in the initial wizard for this. Do you know which one it is and can you write it here. Or is it the generic option?

@setola
Copy link
Contributor Author

setola commented Feb 22, 2019

I was able to make it work with the generic ESP32 board:

esphome:
  name: poetest0
  platform: ESP32
  board: esp-wrover-kit

Other Olimex boards are enlisted, but I didn't tried messing with these.

@OttoWinter OttoWinter merged commit e7fb990 into esphome:current Feb 23, 2019
@esphome esphome locked and limited conversation to collaborators Jun 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants