Skip to content

Conversation

@hmueller01
Copy link
Contributor

This addresses #8967

@hmueller01
Copy link
Contributor Author

@d-a-v Would you mind merging this, or do you have any comments / improvements on this?

@hmueller01
Copy link
Contributor Author

I kindly like to ask, if someone can merge this. I use this in several projects of mine and always have to use this branch instead of the HEAD. This should not break anything as it more or less just adds an additional function and some very minor changes (like the before noted enum, the move _httpClientTimeout, _followRedirects from privateto protected which helps later extention of the class and an information output).

Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d-a-v d-a-v merged commit fb8d6d6 into esp8266:master Nov 4, 2023
hasenradball pushed a commit to hasenradball/Arduino that referenced this pull request Nov 18, 2024
…sp8266#8968)

* added getAvailableVersion(), moved _httpClientTimeout and _followRedirects to protected, added enum HTTPUpdateError

* auto numbering of HTTPUpdateError enum

* added getAvailableVersion(), debug output current current Sketch MD5

* updated advanced updater php script

* switch case indention corrected

* Revert "added getAvailableVersion(), debug output current current Sketch MD5"

This reverts commit 60d2c77.

* Revert "auto numbering of HTTPUpdateError enum"

This reverts commit 61785b2.

* Revert "added getAvailableVersion(), moved _httpClientTimeout and _followRedirects to protected, added enum HTTPUpdateError"

This reverts commit cec84ed.

* corrected incorrect merge with master
@hmueller01 hmueller01 deleted the getAvailableVersion branch October 25, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants