Skip to content

Clean up use of "byte" as a type. uint8_t or (C++17) std::byte are better #8090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2021
Merged

Clean up use of "byte" as a type. uint8_t or (C++17) std::byte are better #8090

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
637a1e9
Clean up use of "byte" as a type. uint8_t or (C++17) std::byte are be…
dok-net May 31, 2021
b6fd9f3
Merge branch 'master' into fix_8089
d-a-v Jul 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cores/esp8266/core_esp8266_main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ static uint32_t s_cycles_at_yield_start;
*/
#define ETS_INTR_LOCK_NEST_MAX 7
static uint16_t ets_intr_lock_stack[ETS_INTR_LOCK_NEST_MAX];
static byte ets_intr_lock_stack_ptr=0;
static uint8_t ets_intr_lock_stack_ptr=0;


extern "C" {
Expand Down
4 changes: 2 additions & 2 deletions libraries/ESP8266WiFiMesh/src/TypeConversionFunctions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ using namespace experimental::TypeConversion;

namespace MeshTypeConversionFunctions
{
String uint64ToString(uint64_t number, const byte base)
String uint64ToString(uint64_t number, const uint8_t base)
{
assert(2 <= base && base <= 36);

Expand All @@ -59,7 +59,7 @@ namespace MeshTypeConversionFunctions
return result;
}

uint64_t stringToUint64(const String &string, const byte base)
uint64_t stringToUint64(const String &string, const uint8_t base)
{
assert(2 <= base && base <= 36);

Expand Down