Add support for hidden SSID's Multi WiFi#7629
Merged
devyte merged 5 commits intoesp8266:masterfrom Jan 21, 2021
Merged
Conversation
devyte
requested changes
Oct 14, 2020
Collaborator
devyte
left a comment
devyte
left a comment
There was a problem hiding this comment.
Minor thing, then I'm good.
Contributor
Author
|
@devyte Thanks for your review and I agree with your changes. Can this automatically be merged, or is a manual interaction needed from me? |
Collaborator
|
Just implement in your local branch, then push. PR will be updated automatically. I'll see that, wait for CI, then merge. |
Contributor
Author
Perfect, I will do that. |
Erriez
force-pushed
the
feature/issue-2246-multi-wifi-hidden
branch
from
83c6b3a to
0d94b5f
Compare
|
@devyte Any chance in review of this? thanks |
devyte
approved these changes
Jan 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for hidden SSID's as discussed with @devyte. Algorithm:
See issue #2246