Fix waveform missing edges on cycle rollover #4945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the ESP cycle counter rolls over, the "now" can be smaller than the next-edge time of a waveform generator. This would cause the edge to be missed on that specific pin, and make it look like PWM was hung. Use proper comparison between current time and edge time. Fixes esp8266#4944 Also remove the "sigma-delta.c.unused" file which was replaced by a working one some time ago.
devyte
approved these changes
Jul 22, 2018
|
Got a little over 8hrs recorded before the logic analyzer aborted. Checked w/o any pwm freezes (on the same run I started about 24hrs ago) so I'm pretty sure we're clean. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the ESP cycle counter rolls over, the "now" can be smaller than the
next-edge time of a waveform generator. This would cause the edge to be
missed on that specific pin, and make it look like PWM was hung.
Use proper comparison between current time and edge time.
Fixes #4944
Also remove the "sigma-delta.c.unused" file which was replaced by a
working one some time ago.