Configurable timeout for WiFiClient connect and write operations #3257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igrr
added a commit
that referenced
this pull request
May 22, 2017
WiFiClient write timeouts introduced in #3257 applied to the whole write operation, which could take long time if data size was large. This change makes the timeout happen per chunk. Timeout now happens if no data has been delivered within a given interval.
Contributor
|
Hi Ivan, how can I set the connect timeout for the ESP8266HTTPClient? |
|
@Jeroen88 Did you found a solution? |
Contributor
|
@aminjoharinia Hi Amin, I think you can use void setTimeout(uint16_t timeout), this passes the timeout to the WiFiClient. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WiFiClient inherits
Stream::setTimeoutmethod. The value passed tosetTimeoutis used byStreammethods likereadBytes,readStringUntiland so on. Other operations with WiFiClient such asconnectandwritepreviously didn't have configurable timeouts.connectwould time out after 5 seconds, andwritewould return only if LwIP reported an error.This change implements timeout during
connectandwrite. Forconnect, same timeout value is used for name resolution and the actual connection, so it is possible that worst case timeout will be twice the timeout requested. For writes,writefunction will return the amount of data sent by the time the timeout has happened.Fixes #1420, #3247, #2120