Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which SDK version is 2.5-beta2 based on? #5521

Closed
marcelstoer opened this issue Dec 18, 2018 · 3 comments
Closed

Which SDK version is 2.5-beta2 based on? #5521

marcelstoer opened this issue Dec 18, 2018 · 3 comments

Comments

@marcelstoer
Copy link
Contributor

Simple question triggered by this comment espressif/ESP8266_NONOS_SDK#8 (comment)

Which SDK version is 2.5-beta2 based on?

The version file says 2.2.0 something while system_get_sdk_version() appears to be saying 3.0.0 something. I tend to believe the latter 😉

@d-a-v
Copy link
Collaborator

d-a-v commented Dec 18, 2018

It's not real 3.0.0
git hash is in tools/sdk/version.
We cherry-picked the "last" v2 before v3 taste,

commit 89920dcc40aee30da11899c832f311e381312b38 (HEAD -> pre3)
Author: Espressif Systems <[email protected]>
Date:   Tue Jun 26 17:43:01 2018 +0800

right before the final serie of commits for v3 and major internal SDK / API changes.

All following commits have another author,

commit cb46633acae2577c68dd7c8d97f34566cfc95b96
Merge: 1498a86 e8d53c1
Author: Xu Chun Guang <[email protected]>
Date:   Thu Jul 12 21:21:38 2018 +0800

The signature of the new era is very visible with gitk. Tube/subway map starts right after that.
I bet on this version for a try, and we finally kept it, until we are ready for v3.
I don't remember whether that was before or after they added this pre3 tag.(ooops, pre3 seems to be a local tag from my local copy)

@devyte devyte closed this as completed Dec 18, 2018
@marcelstoer
Copy link
Contributor Author

@d-a-v thanks for the explanations. Pity the SDK version is embedded in a SDK binary (tools/sdk/lib/libmain.a?) and can't be changed by you. It's not good that we have to live with this inconsistency.

@d-a-v
Copy link
Collaborator

d-a-v commented Dec 19, 2018

To keep track on dependencies and API changes, there is a new constant, visual, comparable with #if or evaluated at compile time with if(), increasing with every commits:
constexpr int coreVersionNumeric() in core_esp8266_version.h.

// Examples:
// case 2.4.2 (fresh version/tag)   20402000
// case 2.4.2-91-gcb05b86d:         20402091
// case 2.5.0-beta3-1-gcb05b86d:    20499903
// case 2.5.0:                      20500000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants