Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transient errors #20

Merged
merged 7 commits into from
Jan 11, 2023
Merged

Fix transient errors #20

merged 7 commits into from
Jan 11, 2023

Conversation

SergioGasquez
Copy link
Member

  • Update Readme
  • Avoid using install.sh
  • Export GITHUB_TOKEN in the CI

MabezDev
MabezDev reviewed Jan 11, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
jessebraham
jessebraham requested changes Jan 11, 2023
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, thanks for fighting your way through to the end with this one. Just would like to see one small change in the README please and otherwise I'm happy to merge this.

README.md Outdated Show resolved Hide resolved
@SergioGasquez SergioGasquez linked an issue Jan 11, 2023 that may be closed by this pull request
Increased rate of transient failures in recent weeks #15
Closed
jessebraham
jessebraham approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for changing that!

@jessebraham jessebraham merged commit 689f3b8 into esp-rs:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebraham jessebraham jessebraham approved these changes

@MabezDev MabezDev Awaiting requested review from MabezDev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increased rate of transient failures in recent weeks
3 participants
@SergioGasquez @jessebraham @MabezDev