-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use espup
#16
Use espup
#16
Conversation
This is looking pretty good, as far as I can tell. Thanks for making these updates, hopefully it will be a bit more reliable. ~2 minutes is acceptable I think, I would still like to get it down a bit but it's reasonable. Something we can work on in the future. Out of curiosity have you tested the workflow with any of the repositories currently using it (eg. |
Once
I've run |
Thanks for testing it out! |
Use
espup
instead ofrust-build
script for installation. This should also solve #15 as it removes the call, and relies on the version check toespup
.Time-wise, the action takes around 2 minutes, the same as the
rust-build
scripts used to last.Also, I've created another branch that improves the cases covered by the CI as many arguments are not covered atm, if we endup merging this PR, I'll create another one for it.