Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve errors #65

Merged
merged 9 commits into from
Nov 16, 2022
Merged

Improve errors #65

merged 9 commits into from
Nov 16, 2022

Conversation

SergioGasquez
Copy link
Member

  • Use fancy feature of miette
  • Return miette::Report instead of Error, as returning Error resulted in something like: 
    Error: XtensaToolchainAlreadyInstalled("/home/esp/.rustup/toolchains/esp")
    Instead of: 
    Error: espup::toolchain::rust::xtensa_rust_already_installed

  × ⛔  Previous installation of Rust Toolchain exists in: '/home/esp/.rustup/toolchains/esp'. Please, remove the directory before new installation.

jessebraham
jessebraham approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SergioGasquez SergioGasquez merged commit 517c753 into main Nov 16, 2022
@SergioGasquez SergioGasquez deleted the feature/improve-errors branch November 16, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebraham jessebraham jessebraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SergioGasquez @jessebraham