Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using hardcoded Xtensa Rust version #38

Merged
merged 8 commits into from
Nov 3, 2022
Merged

Avoid using hardcoded Xtensa Rust version #38

merged 8 commits into from
Nov 3, 2022

Conversation

SergioGasquez
Copy link
Member

  • Get the latest Xtensa Rust toolchain version from the latest release of rust-build repo.
  • If no version is provided to the update and install subcommand is provided, it will use the latest.
  • Add unit test for XtensaRust::parse_version

@SergioGasquez SergioGasquez linked an issue Nov 3, 2022 that may be closed by this pull request
update subcomand should check if latest version is installed, if not, installs it. #14
Closed
jessebraham
jessebraham approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/toolchain/rust.rs Outdated Show resolved Hide resolved
@SergioGasquez SergioGasquez merged commit 26f971f into main Nov 3, 2022
@SergioGasquez SergioGasquez deleted the feature/improve-update branch November 3, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebraham jessebraham jessebraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update subcomand should check if latest version is installed, if not, installs it.
2 participants
@SergioGasquez @jessebraham