Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a typo #36

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Fix a typo #36

merged 1 commit into from
Nov 2, 2022

Conversation

lu-zero
Copy link
Contributor

@lu-zero lu-zero commented Nov 2, 2022

No description provided.

SergioGasquez
SergioGasquez requested changes Nov 2, 2022
View reviewed changes
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, good catch, and thanks for your contribution! Do you mind addressing the suggestions?

src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
@lu-zero
Copy link
Contributor Author

lu-zero commented Nov 2, 2022

Sure, I managed to put a typo in the sed expression ^^;

@SergioGasquez SergioGasquez self-requested a review November 2, 2022 14:37
@SergioGasquez SergioGasquez merged commit a63c920 into esp-rs:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioGasquez SergioGasquez SergioGasquez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lu-zero @SergioGasquez