Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installation retries #142

Merged
merged 3 commits into from
Jan 16, 2023

Conversation

SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Jan 16, 2023

  • When downloading a file, if the output file is already present, we delete and download it again
  • Added a name method to the Installable trait
    • Implemented it for all the components
  • Added retries to install
    • We now do 3 attempts of installing every component
  • We no longer return Err if the Xtensa Toolchain is already present. Instead, we reuse the installation, see espup install should suceed even if the Xtensa Rust toolchain is already installed #138

@SergioGasquez SergioGasquez marked this pull request as ready for review January 16, 2023 11:34
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small typo but otherwise LGTM!

src/main.rs Outdated Show resolved Hide resolved
Co-authored-by: Jesse Braham <[email protected]>
@SergioGasquez SergioGasquez merged commit ff60295 into esp-rs:main Jan 16, 2023
@SergioGasquez SergioGasquez deleted the feature/install-retries branch January 16, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants