Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes and cleanup #125

Merged
merged 4 commits into from
Jan 2, 2023
Merged

Small fixes and cleanup #125

merged 4 commits into from
Jan 2, 2023

Conversation

jessebraham
Copy link
Member

Nothing too interesting here:

  • Don't depend directly on strum_macros, as it is already pulled in by strum's derive feature
  • Use the directories package instead of using both dirs and directories-next
    • Ironically, directories is now more up-to-date than directories-next
  • Fix some small typos in the output, use more consistent quoting
  • Silence the output from invoked script/application when installing Rust
    • This looked out of place in the output; there may be other places where this should be done as well
    • Might be a good idea to pull in the indicatif package and have status spinners for each step in the future?

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for improving espup so much!

@SergioGasquez SergioGasquez merged commit 3e0b164 into esp-rs:main Jan 2, 2023
@SergioGasquez SergioGasquez mentioned this pull request Jan 3, 2023
@jessebraham jessebraham deleted the fixes/misc branch January 13, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants