Feature/async #108
Merged
Feature/async #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JurajSadel
reviewed
Dec 22, 2022
MabezDev
approved these changes
Dec 22, 2022
jessebraham
approved these changes
Dec 22, 2022
Comment on lines
+238
to
241
| for _ in 0..installable_items { | ||
| let names = rx.recv().await.unwrap(); | ||
| exports.extend(names); | ||
| } |
There was a problem hiding this comment.
Suggested change
| for _ in 0..installable_items { | |
| let names = rx.recv().await.unwrap(); | |
| exports.extend(names); | |
| } | |
| while let Some(names) = rx.recv().await { | |
| exports.extend(names); | |
| } |
What you have is fine of course, but maybe this is a bit cleaner?
There was a problem hiding this comment.
I tried this at first, but it was not working correctly (not really sure why). If I use the while loop, the installation will never end, as it gets stuck in the while loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make installation async