Add external processor support #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernQ
commented
Nov 26, 2024
espflash/src/bin/espflash.rs
Outdated
| @@ -30,7 +30,7 @@ pub struct Cli { | |||
| subcommand: Commands, | |||
|
|
|||
| /// Do not check for updates | |||
| #[clap(short, long, global = true, action)] | |||
| #[clap(long, global = true, action)] | |||
There was a problem hiding this comment.
short clashed with some other option's short-name
espflash/src/bin/espflash.rs
Outdated
| @@ -30,7 +30,7 @@ pub struct Cli { | |||
| subcommand: Commands, | |||
|
|
|||
| /// Do not check for updates | |||
| #[clap(short, long, global = true, action)] | |||
| #[clap(long, global = true, action)] | |||
There was a problem hiding this comment.
I guess it clashed with flash_size, maybe we could use another short instead of removing it
Suggested change
| #[clap(long, global = true, action)] | |
| #[clap(short = 'S', long, global = true, action)] |
No real reason other than I never used it - can add it |
I think it would be good to add it to maintain feature parity as long as we can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option
--processorswhich enables external executables to pre-process data received from the target in monitoring mode.I have a couple of things in mind I want to build upon this since adding those functionalities to
espflashitself would be problematic (in terms of growing code size, maintainability, and additional dependencies)