-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add commands reset
and hold-in-reset
#644
Add commands reset
and hold-in-reset
#644
Conversation
eb27335
to
eed83f8
Compare
Sorry for the noise here. I cherry-picked this from a branch that was based on 2.1.0. I'll clean it up shortly. |
Ok, the mess is cleaned up now. Please let me know what you think. I considered whether to add these commands to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! The commands can be handy for some users! I would also add the commands for cargo-espflash
as some user might not use both tools as you do.
Sounds good, I will do so. |
@SergioGasquez: Thanks for your review! I've updated this set of changes to also add these commands to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the contribution!
Ups! I just noticed that we forgot to update the usage section of cargo-espflash and espflash, mind updating it? Sorry Edit: Let me know if you prefer me to do it, and we can merge it as it is and I'll update the usage section in a different PR |
@SergioGasquez: I just pushed this fix. Thanks for catching that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the features!
We found these commands to be useful for our team.