fix: musl list ports handle /dev/* from available_ports #635
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've been trying to use espflash from Alpine linux and on my system
serialport::available_ports()
returns something like[SerialPortInfo { port_name: "/dev/ttyS0", port_type: Unknown }, SerialPortInfo { port_name: "/dev/ttyUSB0", port_type: Unknown }]
. The function that handles this expectsport_name
to be in the form of/sys/class/tty/*
and this makes espflash not work on my system due to being unable to detect any serial ports.In this PR I've added a branch which checks if the path returned from
available_ports
starts with/dev/
and if it does it replaces it with/sys/class/tty/
and proceeds as before. I can confirm this works for flashing esp32c3 board I'm working with.I'm not sure this is the best approach but at least it works now. Let me know if you think this can be improved in an obvious way.