Implement reset strategies #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 6, 2023
This was referenced Oct 6, 2023
Closed
SergioGasquez
commented
Oct 9, 2023
SergioGasquez
force-pushed
the
fix/resets
branch
2 times, most recently
from
e3822b1 to
322f5a9
Compare
SergioGasquez
force-pushed
the
fix/resets
branch
from
322f5a9 to
1f482ba
Compare
SergioGasquez
force-pushed
the
fix/resets
branch
2 times, most recently
from
843e8ab to
1f482ba
Compare
jessebraham
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR based on @jessebraham work in #344, I didn't rebase because there were a lot of conflicts and wanted to manually review the changes while comparing them with
esptool.There are only some small differences:
libcinstead ofnixcrate inset_dtr_rtstiocmsetwas returning an error.Related issues/PRs: #349, #344, #323, #394, #387
Maybe related: #442, #450
Draft PR until some affected user can verify that it's working@georgik did some testing and confirmed that it's working!