Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the esp-idf-part package #243

Merged
merged 5 commits into from
Sep 27, 2022
Merged

Conversation

jessebraham
Copy link
Member

@jessebraham jessebraham commented Sep 23, 2022

This new package has not been released yet which is why this is a draft, but I don't anticipate any major changes to the library. I will eventually transfer it to esp-rs but for now it's living under my namespace:

https://github.com/jessebraham/esp-idf-part/

These changes bump the MSRV to 1.60.0 from 1.59.0.

Once I have published a release of esp-idf-part (or whatever it ends up being named) I will update this PR. I will rebase as needed until that point.

I have not really tested this with any real hardware yet, so I will do so and make any necessary fixes.

@jessebraham
Copy link
Member Author

esp-idf-part has been published so this PR should be ready to go.

@jessebraham jessebraham marked this pull request as ready for review September 26, 2022 18:08
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Good idea to extract the functionality! Also testing with a somewhat more complex partitions.csv worked fine

@bjoernQ bjoernQ merged commit fab4b7a into esp-rs:master Sep 27, 2022
@jessebraham jessebraham deleted the feature/esp-idf-part branch September 27, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants