Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add static IP and socket listening example #95

Merged
merged 2 commits into from
Dec 1, 2022
Merged

Add static IP and socket listening example #95

merged 2 commits into from
Dec 1, 2022

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Dec 1, 2022

  • add an example using a static IP instead of DHCP
  • add a way to listen on a port to the TcpSocket utils
  • show how to use that

MabezDev
MabezDev approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nitpick :)

README.md Outdated
@@ -8,7 +8,7 @@ WiFi / BTLE coexistence is implemented but currently only works (to some extend)

On ESP32-S3 only WiFi is currently supported.

THIS CURRENTLY DOESN'T WORK WITH THE XTENSA ENABLED RUST COMPILER 1.63.0.2. Use 1.64.0.0!
THIS CURRENTLY DOESN'T WORK WITH THE XTENSA ENABLED RUST COMPILER 1.63.0.2. Use 1.65 or better
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we just rewrite this as "minimum support Rust compiler version: 1.65.0.0"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! Will do

examples/static_ip.rs
<html>\
<body>\
<h1>Hello Rust! Hello esp-wifi!</h1>\
<img src=\"https://rustacean.net/more-crabby-things/dancing-ferris.gif\"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch :D

@bjoernQ bjoernQ merged commit 4739f15 into main Dec 1, 2022
@bjoernQ bjoernQ deleted the server-socket-example branch December 1, 2022 16:28
@bjoernQ bjoernQ mentioned this pull request Dec 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MabezDev MabezDev MabezDev approved these changes

@jessebraham jessebraham Awaiting requested review from jessebraham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjoernQ @MabezDev