Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set wokwi_board #128

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Set wokwi_board #128

merged 1 commit into from
Nov 30, 2023

Conversation

SergioGasquez
Copy link
Member

wokwi_board was not being set, hence the diagram.json did not include the board.

bjoernQ
bjoernQ approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SergioGasquez SergioGasquez merged commit 9292f70 into esp-rs:main Nov 30, 2023
168 checks passed
@SergioGasquez SergioGasquez deleted the fix/wokwi-board branch November 30, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SergioGasquez @bjoernQ