Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Don't enable TX-INTERRUPT on ESP32-S2 #10

Merged
merged 2 commits into from
Aug 17, 2022

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Aug 17, 2022

On ESP32-S2 the code enabled the TX-INTERRUPT - it's not necessary and can cause issues.

e.g. the serial_interrupts in esp-hal won't work when using println! in the example - this fixes it
Also, the crate's version is bumped to 0.2.2 to prepare a release

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Maybe this can fix some of the weird issues we're seeing with the S2...

@MabezDev MabezDev merged commit f89e175 into main Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants