Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various small CI updates #998

Merged
merged 5 commits into from
Dec 5, 2023
Merged

Various small CI updates #998

merged 5 commits into from
Dec 5, 2023

Conversation

jessebraham
Copy link
Member

I still have not really touched the chip-specific HAL packages' workflows, if anybody has any suggestions how these could be improved please let me know, happy to make additional changes. I've at least added checks for some features which were not being previously tested in other packages.

CC @bjoernQ @MabezDev @bugadani

@jessebraham jessebraham added the skip-changelog No changelog modification needed label Dec 5, 2023
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Nice improvements

@bugadani
Copy link
Contributor

bugadani commented Dec 5, 2023

I would suggest maybe adding a collecting ci feature to esp-riscv-rt. The CI config now lists a LOT of features and I think changing the crate might mean the tested and available let of features may drift out of sync.

@jessebraham
Copy link
Member Author

Ahh yeah that's a good idea, thanks for the suggestion! Will add that in a bit.

@jessebraham jessebraham added this pull request to the merge queue Dec 5, 2023
Merged via the queue into esp-rs:main with commit b88a2eb Dec 5, 2023
17 checks passed
@jessebraham jessebraham deleted the fixes/ci branch December 5, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants