Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rwtext after other RAM data sections #464

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Conversation

MabezDev
Copy link
Member

I have to admit, I'm not entirely sure why this works, but I do know the ordering of some sections matters so I guess that's it. I ran all the other examples for the C6 to check for regressions, and the rest still worked.

I also added some gitignore updates because I'm really really tired of having to remember the debug & wokwi configurations :D, let me know if this is an issue though and I'll remove it.

Closes #462

Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! The rtc_watchdog and bunch of other random examples I tried work fine for me,

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MabezDev MabezDev merged commit 7ab9d91 into esp-rs:main Mar 31, 2023
i404788 pushed a commit to i404788/esp-hal that referenced this pull request Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESP32C6 rtc_example is panicking with BorrowMutError
3 participants