Merged
Conversation
MabezDev
force-pushed
the
esp-1.85.0.0-testing
branch
2 times, most recently
from
bf7ceee to
b6cf2db
Compare
bugadani
reviewed
Feb 18, 2025
| const PSRAM_EID_SIZE_S: u32 = 5; | ||
|
|
||
| let size_id = (((dev_id) >> PSRAM_ID_EID_S) & PSRAM_ID_EID_M) >> PSRAM_EID_SIZE_S | ||
| let size_id = ((((dev_id) >> PSRAM_ID_EID_S) & PSRAM_ID_EID_M) >> PSRAM_EID_SIZE_S) |
Contributor
|
Yikes, we're missing a lot of bits from the PACs... |
Member
Author
|
Marking as ready for review, we'll want these clippy changes in, and we'll also want to be testing the 1.85 compiler a bit so we can convert to latest at some point.
Yeah a lot of the PSRAM (and a lot of the soc module in general) is missing from the PACs :( |
MabezDev
force-pushed
the
esp-1.85.0.0-testing
branch
from
b6cf2db to
c04dea2
Compare
bugadani
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
Please provide a clear and concise description of your changes, including the motivation behind these changes. The context is crucial for the reviewers.
Testing
Describe how you tested your changes.