Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove i2c::SetupError and make i2c::I2C::new infallible #281

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

dimpolo
Copy link
Contributor

@dimpolo dimpolo commented Nov 29, 2022

This is a breaking change.
Closes #278

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for your contribution

@bjoernQ bjoernQ merged commit 5f4a7b5 into esp-rs:main Nov 29, 2022
@dimpolo dimpolo deleted the RemoveSetupError branch December 5, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#263 made I2C::new() infallible
2 participants