Update to newest embedded-hal alpha and add embedded-hal-nb
#203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! Didn't merge since I'm not sure if you wanted to add anything or not
That's good - I recently wondered why cargo was pulling in eh1 when it wasn't activated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #202 (since I'm modifying the examples in both, which would otherwise cause a merge conflict) so leaving it as draft until that's been merged. Can rebase after that.
The first alpha releases of
embedded-hal-nbhave been released, along with a new alpha version ofembedded-hal. This PR updates our HALs to use these packages.I also gated the dependencies behind the feature in the chip-specific HALs like we do in
esp-hal-common, because why not.