Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update probe-rs arguments for run-elfs subcommand #1734

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

SergioGasquez
Copy link
Member

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

Now that we fix the C2 HIL setup, probe-rs was failing to flash the tests after the first test, this should make C2 HIL tests pass.

Testing

I've downloaded the C2 test artifacts from the CI and run them using cargo xtask run-elfs esp32c2 /home/sergio/Downloads/tests-esp32c2 (without the changes on this PR, it fails the same way).

@SergioGasquez SergioGasquez added the skip-changelog No changelog modification needed label Jun 28, 2024
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, hopefully this works! 🤞🏻

@jessebraham jessebraham added this pull request to the merge queue Jun 28, 2024
Merged via the queue into esp-rs:main with commit 60b9d5c Jun 28, 2024
30 checks passed
@SergioGasquez SergioGasquez deleted the fix/c2-hil branch June 28, 2024 14:01
@SergioGasquez
Copy link
Member Author

Just added HIL Test | esp32c2 to the required checks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants