Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog CI #1725

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Conversation

SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Jun 27, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

Testing

Tested in my fork with the following PR SergioGasquez#3 which has some commits modifying some packages without changing the changelog to make it fail

@SergioGasquez SergioGasquez added the skip-changelog No changelog modification needed label Jun 27, 2024
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this, I think this LGTM. Not really sure how we go about testing/verifying this, I guess we just need to merge it and hope for the best? 😅

@SergioGasquez
Copy link
Member Author

Not really sure how we go about testing/verifying this, I guess we just need to merge it and hope for the best?

Just tested it in my fork with the following PR SergioGasquez#3 which has some commits modifying some packages without changing the changelog to make it fail

@jessebraham jessebraham added this pull request to the merge queue Jun 28, 2024
Merged via the queue into esp-rs:main with commit 3af45a2 Jun 28, 2024
30 checks passed
@SergioGasquez SergioGasquez deleted the feat/changelog-ci branch June 28, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CHANGELOG.md checks should check any packages with changes, not just esp-hal
3 participants