Skip to content

Conversation

@jessebraham
Copy link
Member

@jessebraham jessebraham commented May 30, 2024

The feed bit is the highest bit, so I guess that the previous implementation was setting the lowest bit instead.

Closes #1534

@jessebraham
Copy link
Member Author

Ahh classic forgot to check the other chips 😁


self.set_write_protection(false);
rtc_cntl.wdtfeed().write(|w| unsafe { w.bits(1) });
#[cfg(any(esp32c6, esp32h2))]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sucks, but I already published new PACs for the upcoming release. I will update the PACs in the repo, then make a note to fix this after we've published.

Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bjoernQ bjoernQ added this pull request to the merge queue May 31, 2024
Merged via the queue into esp-rs:main with commit 2fd1594 May 31, 2024
@jessebraham jessebraham deleted the fixes/rwdt branch May 31, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rwdt feeding doesn't seem to work

3 participants