Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPIO: Use Level enum instead of plain bool in constructors #1574

Merged
merged 2 commits into from
May 22, 2024

Conversation

JurajSadel
Copy link
Contributor

@JurajSadel JurajSadel commented May 22, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

GPIO constructors now take Level enum instead of plain bool arguments.

Testing

Run related examples.

closes #1569

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@bjoernQ bjoernQ added this pull request to the merge queue May 22, 2024
Merged via the queue into esp-rs:main with commit 60d39e9 May 22, 2024
22 checks passed
@JurajSadel JurajSadel deleted the cleanup branch May 23, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gpio::Output::new still have plain bool argument
3 participants