Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PACs and fix resulting errors, convert IEEE802154 from virtual to real peripheral #1549

Merged
merged 2 commits into from
May 10, 2024
Merged

Update PACs and fix resulting errors, convert IEEE802154 from virtual to real peripheral #1549

merged 2 commits into from
May 10, 2024

Conversation

jessebraham
Copy link
Member

The IEEE802154 registers are now in the PACs, so we can use this peripheral like any other now.

@jessebraham jessebraham added the skip-changelog No changelog modification needed label May 9, 2024
bjoernQ
bjoernQ approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JurajSadel
JurajSadel approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JurajSadel JurajSadel added this pull request to the merge queue May 10, 2024
Merged via the queue into esp-rs:main with commit 865823c May 10, 2024
23 checks passed
@jessebraham jessebraham deleted the feature/updates branch May 13, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

@JurajSadel JurajSadel JurajSadel approved these changes

Assignees
No one assigned
Labels
skip-changelog No changelog modification needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jessebraham @bjoernQ @JurajSadel