[1/3] Timer abstraction: refactor systimer and timer modules into a common timer module
#1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 2, 2024
… a common `timer` module (#1527) * Refactor `systimer` and `timer` modules into a common `timer` module * Update `CHANGELOG.md`
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
jessebraham
force-pushed
the
feature/timer-abstraction-0
branch
from
fdacabb
to
bbebb64
Compare
MabezDev
pushed a commit
to MabezDev/esp-hal
that referenced
this pull request
May 2, 2024
… a common `timer` module (esp-rs#1527) * Refactor `systimer` and `timer` modules into a common `timer` module * Update `CHANGELOG.md` * Rebase and update new example
MabezDev
pushed a commit
to MabezDev/esp-hal
that referenced
this pull request
May 2, 2024
… a common `timer` module (esp-rs#1527) * Refactor `systimer` and `timer` modules into a common `timer` module * Update `CHANGELOG.md` * Rebase and update new example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've decided to split this work up into a few PRs, as otherwise I think it will be rather difficult to review.
This first PR is simply refactoring the
systimerandtimermodules into a commontimermodule, now available at the pathstimer::systimerandtimer::timgrespectively. This is a breaking change, but a minor one.The next PR will add the
Timertrait and implement theOneShotTimerandPeriodicTimertypes.The third and final PR will include documentation, plus probably some refactoring/cleanup.