Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ESP32S2 #9

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Add ESP32S2 #9

merged 1 commit into from
Dec 9, 2022

Conversation

JurajSadel
Copy link
Contributor

No description provided.

jessebraham
jessebraham approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small suggestions, but looks good overall!

src/main.rs Outdated Show resolved Hide resolved
src/serial_io.rs Outdated Show resolved Hide resolved
bjoernQ
bjoernQ approved these changes Dec 9, 2022
View reviewed changes
Copy link

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JurajSadel
Copy link
Contributor Author

Thank you @jessebraham and @bjoernQ

@JurajSadel JurajSadel merged commit f72587e into esp-rs:main Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebraham jessebraham jessebraham approved these changes

@bjoernQ bjoernQ bjoernQ approved these changes

@MabezDev MabezDev Awaiting requested review from MabezDev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JurajSadel @jessebraham @bjoernQ