fix: Fix the ESP32-S2 security info response size #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ESP32-S2 ROM GET_SECURITY_INFO response does not contain chip_id and api_version fields. Currently, the flasher stub just returns 0 and 0 for these, however chip_id 0 is reserved for the ESP32. This makes the stub behavior in line with the ROM. Closes esp-rs#65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ESP32-S2 ROM
GET_SECURITY_INFOresponse does not containchip_idandapi_versionfields.Currently, the flasher stub just returns 0 and 0 for these, however chip_id 0 is reserved for the ESP32.
This makes the stub behavior in line with the ROM.
Since this is a single-chip workaround,
cfgwas chosen instead of creating new traits or using a generic, however that can be remedied in the future if new chips come out with different response sizes.Closes #65